WD-8399 - Create add secrets panel #1692
Conversation
|
Demo starting at https://juju-dashboard-1692.demos.haus |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 95.13% 95.04% -0.10%
==========================================
Files 179 182 +3
Lines 5306 5325 +19
Branches 1540 1545 +5
==========================================
+ Hits 5048 5061 +13
- Misses 238 243 +5
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. |
| import AddSecretPanel, { TestId } from "./AddSecretPanel"; | ||
|
|
||
| describe("AddSecretPanel", () => { | ||
| it("renders", async () => { |
There was a problem hiding this comment.
This is just a placeholder test for when the functionality is added in https://warthogs.atlassian.net/browse/WD-8546.
| label: "", | ||
| rotatePolicy: RotatePolicy.NEVER, | ||
| }} | ||
| onSubmit={(values) => { |
There was a problem hiding this comment.
This is where the secret will be created in https://warthogs.atlassian.net/browse/WD-8546.
| import Fields from "./Fields"; | ||
|
|
||
| describe("Fields", () => { | ||
| it("renders", async () => { |
There was a problem hiding this comment.
This is just a placeholder test for when the functionality is added in https://warthogs.atlassian.net/browse/WD-8546.
src/panels/Panels.tsx
Outdated
| @@ -25,6 +26,8 @@ export default function Panels() { | |||
| return <ConfigPanel />; | |||
| case "audit-log-filters": | |||
| return <AuditLogsFilterPanel />; | |||
| case "add-secret": | |||
| return <AddSecret />; | |||
There was a problem hiding this comment.
I see that we use the "Panel" suffix for the names of all the previous panels. For consistency reasons, maybe it makes sense to name this something like "AddSecretPanel"?
vladimir-cucu
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-8399
Screenshots